apache-mynewt-bot commented on issue #2155: WIP - add travis checking of coding style URL: https://github.com/apache/mynewt-core/pull/2155#issuecomment-575186528 ## Style check summary #### kernel/os/src/os_task.c <details> ```diff @@ -58,8 +58,8 @@ int os_task_init(struct os_task *t, const char *name, os_task_func_t func, - void *arg, uint8_t prio, os_time_t sanity_itvl, - os_stack_t *stack_bottom, uint16_t stack_size) + void *arg, uint8_t prio, os_time_t sanity_itvl, + os_stack_t *stack_bottom, uint16_t stack_size) { struct os_sanity_check *sc; int rc; @@ -148,22 +148,20 @@ /* * If state is not READY or SLEEP, assume task has not been initialized */ - if (t->t_state != OS_TASK_READY && t->t_state != OS_TASK_SLEEP) - { + if (t->t_state != OS_TASK_READY && t->t_state != OS_TASK_SLEEP) { return OS_NOT_STARTED; } - if( t->t_state!=OS_TASK_READY - && t->t_state!=OS_TASK_SLEEP ) - { - return (OS_NOT_STARTED); + if (t->t_state != OS_TASK_READY + && t->t_state != OS_TASK_SLEEP) { + return (OS_NOT_STARTED); } /* * Disallow suspending tasks which are waiting on a lock */ if (t->t_flags & (OS_TASK_FLAG_SEM_WAIT | OS_TASK_FLAG_MUTEX_WAIT | - OS_TASK_FLAG_EVQ_WAIT)) { + OS_TASK_FLAG_EVQ_WAIT)) { return OS_EBUSY; } ``` </details> #### mgmt/imgmgr/src/imgmgr_cli.c <details> ```diff @@ -44,11 +44,11 @@ #if MYNEWT_VAL(SHELL_CMD_HELP) static const struct shell_cmd_help imgr_cli_help = { - .summary = "image management command", - .usage = "\n" - " imgr list\n" - " imgr test <slot | hash>\n" - " imgr confirm [slot | hash]" + .summary = "image management command", + .usage = "\n" + " imgr list\n" + " imgr test <slot | hash>\n" + " imgr confirm [slot | hash]" }; #endif @@ -66,8 +66,9 @@ console_printf("Too few args\n"); } -// copy/pasta for testing -static void imgr_cli_too_few_args_(void) { +/* copy/pasta for testing */ +static void +imgr_cli_too_few_args_(void) { console_printf("Too few args\n"); } ``` </details>
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
