utzig commented on a change in pull request #373: Fix some issues reported by
Coverity
URL: https://github.com/apache/mynewt-newt/pull/373#discussion_r371786203
##########
File path: newt/toolchain/compiler.go
##########
@@ -1374,7 +1373,7 @@ func (c *Compiler) CopySymbols(infile string, outfile
string, sm *symbol.SymbolM
if err != nil {
return err
}
- return err
+ return nil
Review comment:
I don't understand this issue and the one above it, if `err` is being tested
for non-`nil` value above could it be anything different than `nil` in the
`return`? (Non related to the question, I guess the test above could be removed
for this one). The other changes in this PR look good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
