ccollins476ad commented on a change in pull request #2175: da1469x: add initial crypto driver URL: https://github.com/apache/mynewt-core/pull/2175#discussion_r374236065
########## File path: hw/drivers/crypto/crypto_da1469x/src/crypto_da1469x.c ########## @@ -0,0 +1,236 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#include <string.h> +#include "mcu/cmsis_nvic.h" Review comment: Jumping in here... This is a pedantic answer. The original code looks correct to me. From the C spec (C11 draft, 6.10.2, "Source file inclusion") (http://www.iso-9899.info/n1570.html): > A preprocessing directive of the form > ```# include <h-char-sequence> new-line``` > searches a sequence of implementation-defined places for a header identified uniquely by the specified sequence between the < and > delimiters, and causes the replacement of that directive by the entire contents of the header. How the places are specified or the header identified is implementation-defined. > > A preprocessing directive of the form ```# include "q-char-sequence" new-line``` > causes the replacement of that directive by the entire contents of the source file identified by the specified sequence between the " delimiters. The named source file is searched for in an implementation-defined manner. If this search is not supported, or if the search fails, the directive is reprocessed as if it read ```# include <h-char-sequence> new-line``` > with the identical contained sequence (including > characters, if any) from the original directive. In other words, `<>` is used to include headers from the *implementation* (compiler, linker, etc.). `""` is used for everything else. In practice there is not much difference. I believe gcc searches implementation-specific directories first when `<>` is used, but last when `""` is used. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
