andrzej-kaczmarek commented on a change in pull request #744: [WIP] Add support
for Enhanced LE CoC as per BT 5.2
URL: https://github.com/apache/mynewt-nimble/pull/744#discussion_r375263111
##########
File path: nimble/host/src/ble_l2cap_sig_priv.h
##########
@@ -103,13 +129,24 @@ void *ble_l2cap_sig_cmd_get(uint8_t opcode, uint8_t id,
uint16_t len,
int ble_l2cap_sig_coc_connect(uint16_t conn_handle, uint16_t psm, uint16_t mtu,
struct os_mbuf *sdu_rx,
ble_l2cap_event_fn *cb, void *cb_arg);
+int ble_l2cap_sig_coc_connect_multiple(uint16_t conn_handle,
+ uint16_t psm, uint16_t mtu,
+ uint8_t num, struct os_mbuf *sdu_rx[num],
+ ble_l2cap_event_fn *cb, void *cb_arg);
int ble_l2cap_sig_disconnect(struct ble_l2cap_chan *chan);
int ble_l2cap_sig_le_credits(uint16_t conn_handle, uint16_t scid,
uint16_t credits);
+int ble_l2cap_sig_coc_reconfig(uint16_t conn_handle, uint16_t new_mtu,
+ uint8_t cnt, struct ble_l2cap_chan *chans[]);
#else
#define ble_l2cap_sig_coc_connect(conn_handle, psm, mtu, sdu_rx, cb, cb_arg) \
BLE_HS_ENOTSUP
+
+#define ble_l2cap_sig_coc_connect_multiple(conn_handle, psm, mtu, num, sdu_rx,
\
+ cb, cb_arg) BLE_HS_ENOTSUP
+
#define ble_l2cap_sig_disconnect(chan) BLE_HS_ENOTSUP
+#define ble_l2cap_sig_coc_reconfig(conn_handle, new_mtu, cnt, chans)
BLE_HS_ENOTSUP
Review comment:
`BLE_VERSION` ifdef is done in a different way, we should be consistent. I
do not like the one above, so either do as for `BLE_VERSION` or use `static
inline` to simply return `BLE_HS_ENOTSUP`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
