kasjer commented on issue #2196: Full console: suppress new line when echo is disabled URL: https://github.com/apache/mynewt-core/pull/2196#issuecomment-591001807 Hi @dwld, I tell you why this takes so much time with such simple reasonable change. For a long time console code that was modified by a few people did not really handled few control characters resulting in some echo while console was configured to be silent except for NLIP protocol. In late 2019 I changed it so not echo for CR LF (and other control characters showed) but one company that uses mynewt was affected since they relayed on this not so obvious behavior. So 153dfb8b7d13f0cf16298fd6e3b5235909fe2f30 restored echo for CR/LF just as not to break `backward compatibility`. I probably should have add conditional code for allowing this echo if someone really needs it, instead of always, which is not something that would be expected from the code. So that is why no one is rushing to accept this.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
