apache-mynewt-bot commented on issue #2232: BSP for Adafruit Feather STM32F405 
Express
URL: https://github.com/apache/mynewt-core/pull/2232#issuecomment-596263828
 
 
   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### hw/bsp/ada_feather_stm32f405/include/bsp/stm32f4xx_hal_conf.h
   <details>
   
   ```diff
   @@ -1,39 +1,39 @@
    /**
   -  
******************************************************************************
   -  * @file    stm32f4xx_hal_conf.h
   -  * @author  MCD Application Team
   -  * @version V1.2.4
   -  * @date    06-May-2016
   -  * @brief   HAL configuration file
   -  
******************************************************************************
   -  * @attention
   -  *
   -  * <h2><center>&copy; COPYRIGHT(c) 2016 STMicroelectronics</center></h2>
   -  *
   -  * Redistribution and use in source and binary forms, with or without 
modification,
   -  * are permitted provided that the following conditions are met:
   -  *   1. Redistributions of source code must retain the above copyright 
notice,
   -  *      this list of conditions and the following disclaimer.
   -  *   2. Redistributions in binary form must reproduce the above copyright 
notice,
   -  *      this list of conditions and the following disclaimer in the 
documentation
   -  *      and/or other materials provided with the distribution.
   -  *   3. Neither the name of STMicroelectronics nor the names of its 
contributors
   -  *      may be used to endorse or promote products derived from this 
software
   -  *      without specific prior written permission.
   -  *
   -  * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS 
IS"
   -  * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, 
THE
   -  * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 
PURPOSE ARE
   -  * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE 
LIABLE
   -  * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR 
CONSEQUENTIAL
   -  * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS 
OR
   -  * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) 
HOWEVER
   -  * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT 
LIABILITY,
   -  * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF 
THE USE
   -  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
   -  *
   -  
******************************************************************************
   -  */
   + 
******************************************************************************
   + * @file    stm32f4xx_hal_conf.h
   + * @author  MCD Application Team
   + * @version V1.2.4
   + * @date    06-May-2016
   + * @brief   HAL configuration file
   + 
******************************************************************************
   + * @attention
   + *
   + * <h2><center>&copy; COPYRIGHT(c) 2016 STMicroelectronics</center></h2>
   + *
   + * Redistribution and use in source and binary forms, with or without 
modification,
   + * are permitted provided that the following conditions are met:
   + *   1. Redistributions of source code must retain the above copyright 
notice,
   + *      this list of conditions and the following disclaimer.
   + *   2. Redistributions in binary form must reproduce the above copyright 
notice,
   + *      this list of conditions and the following disclaimer in the 
documentation
   + *      and/or other materials provided with the distribution.
   + *   3. Neither the name of STMicroelectronics nor the names of its 
contributors
   + *      may be used to endorse or promote products derived from this 
software
   + *      without specific prior written permission.
   + *
   + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS 
IS"
   + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
   + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 
PURPOSE ARE
   + * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE 
LIABLE
   + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR 
CONSEQUENTIAL
   + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS 
OR
   + * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) 
HOWEVER
   + * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT 
LIABILITY,
   + * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF 
THE USE
   + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
   + *
   + 
******************************************************************************
   + */
    
    /* Define to prevent recursive inclusion 
-------------------------------------*/
    #ifndef __STM32F4xx_HAL_CONF_H
   @@ -42,7 +42,7 @@
    #include <syscfg/syscfg.h>
    
    #ifdef __cplusplus
   - extern "C" {
   +extern "C" {
    #endif
    
    /* Exported types 
------------------------------------------------------------*/
   @@ -50,8 +50,8 @@
    
    /* ########################## Module Selection 
############################## */
    /**
   -  * @brief This is the list of modules to be used in the HAL driver
   -  */
   + * @brief This is the list of modules to be used in the HAL driver
   + */
    #define HAL_MODULE_ENABLED
    #if 0
    #define HAL_ADC_MODULE_ENABLED
   @@ -109,10 +109,10 @@
    
    /* ########################## HSE/HSI Values adaptation 
##################### */
    /**
   -  * @brief Adjust the value of External High Speed oscillator (HSE) used in 
your application.
   -  *        This value is used by the RCC HAL module to compute the system 
frequency
   -  *        (when HSE is used as system clock source, directly or through 
the PLL).
   -  */
   + * @brief Adjust the value of External High Speed oscillator (HSE) used in 
your application.
   + *        This value is used by the RCC HAL module to compute the system 
frequency
   + *        (when HSE is used as system clock source, directly or through the 
PLL).
   + */
    #if !defined  (HSE_VALUE)
      #define HSE_VALUE    ((uint32_t)12000000) /*!< Value of the External 
oscillator in Hz */
    #endif /* HSE_VALUE */
   @@ -122,25 +122,25 @@
    #endif /* HSE_STARTUP_TIMEOUT */
    
    /**
   -  * @brief Internal High Speed oscillator (HSI) value.
   -  *        This value is used by the RCC HAL module to compute the system 
frequency
   -  *        (when HSI is used as system clock source, directly or through 
the PLL).
   -  */
   + * @brief Internal High Speed oscillator (HSI) value.
   + *        This value is used by the RCC HAL module to compute the system 
frequency
   + *        (when HSI is used as system clock source, directly or through the 
PLL).
   + */
    #if !defined  (HSI_VALUE)
      #define HSI_VALUE    ((uint32_t)16000000) /*!< Value of the Internal 
oscillator in Hz*/
    #endif /* HSI_VALUE */
    
    /**
   -  * @brief Internal Low Speed oscillator (LSI) value.
   -  */
   + * @brief Internal Low Speed oscillator (LSI) value.
   + */
    #if !defined  (LSI_VALUE)
     #define LSI_VALUE  ((uint32_t)32000)
    #endif /* LSI_VALUE */                      /*!< Value of the Internal Low 
Speed oscillator in Hz
                                                 The real value may vary 
depending on the variations
                                                 in voltage and temperature.  */
    /**
   -  * @brief External Low Speed oscillator (LSE) value.
   -  */
   + * @brief External Low Speed oscillator (LSE) value.
   + */
    #if !defined  (LSE_VALUE)
     #define LSE_VALUE  ((uint32_t)32768)    /*!< Value of the External Low 
Speed oscillator in Hz */
    #endif /* LSE_VALUE */
   @@ -150,10 +150,10 @@
    #endif /* LSE_STARTUP_TIMEOUT */
    
    /**
   -  * @brief External clock source for I2S peripheral
   -  *        This value is used by the I2S HAL module to compute the I2S 
clock source
   -  *        frequency, this source is inserted directly through I2S_CKIN pad.
   -  */
   + * @brief External clock source for I2S peripheral
   + *        This value is used by the I2S HAL module to compute the I2S clock 
source
   + *        frequency, this source is inserted directly through I2S_CKIN pad.
   + */
    #if !defined  (EXTERNAL_CLOCK_VALUE)
      #define EXTERNAL_CLOCK_VALUE    ((uint32_t)12288000) /*!< Value of the 
Internal oscillator in Hz*/
    #endif /* EXTERNAL_CLOCK_VALUE */
   @@ -163,8 +163,8 @@
    
    /* ########################### System Configuration 
######################### */
    /**
   -  * @brief This is the HAL system configuration section
   -  */
   + * @brief This is the HAL system configuration section
   + */
    #define  VDD_VALUE                    ((uint32_t)3300) /*!< Value of VDD in 
mv */
    #define  TICK_INT_PRIORITY            ((uint32_t)0x0F) /*!< tick interrupt 
priority */
    #define  USE_RTOS                     0
   @@ -174,9 +174,9 @@
    
    /* ########################## Assert Selection 
############################## */
    /**
   -  * @brief Uncomment the line below to expanse the "assert_param" macro in 
the
   -  *        HAL drivers code
   -  */
   + * @brief Uncomment the line below to expanse the "assert_param" macro in 
the
   + *        HAL drivers code
   + */
    /* #define USE_FULL_ASSERT    1 */
    
    /* ################## Ethernet peripheral configuration 
##################### */
   @@ -248,16 +248,16 @@
    /* ################## SPI peripheral configuration 
########################## */
    
    /* CRC FEATURE: Use to activate CRC feature inside HAL SPI Driver
   -* Activated: CRC code is present inside driver
   -* Deactivated: CRC code cleaned from driver
   -*/
   + * Activated: CRC code is present inside driver
   + * Deactivated: CRC code cleaned from driver
   + */
    
    #define USE_SPI_CRC                     0U
    
    /* Includes 
------------------------------------------------------------------*/
    /**
   -  * @brief Include module's header file
   -  */
   + * @brief Include module's header file
   + */
    
    #ifdef HAL_RCC_MODULE_ENABLED
      #include "stm32f4xx_hal_rcc.h"
   @@ -410,16 +410,16 @@
    /* Exported macro 
------------------------------------------------------------*/
    #ifdef  USE_FULL_ASSERT
    /**
   -  * @brief  The assert_param macro is used for function's parameters check.
   -  * @param  expr: If expr is false, it calls assert_failed function
   -  *         which reports the name of the source file and the source
   -  *         line number of the call that failed.
   -  *         If expr is true, it returns no value.
   -  * @retval None
   -  */
   + * @brief  The assert_param macro is used for function's parameters check.
   + * @param  expr: If expr is false, it calls assert_failed function
   + *         which reports the name of the source file and the source
   + *         line number of the call that failed.
   + *         If expr is true, it returns no value.
   + * @retval None
   + */
      #define assert_param(expr) ((expr) ? (void)0 : assert_failed((uint8_t 
*)__FILE__, __LINE__))
    /* Exported functions 
------------------------------------------------------- */
   -  void assert_failed(uint8_t* file, uint32_t line);
   +void assert_failed(uint8_t * file, uint32_t line);
    #else
      #define assert_param(expr) ((void)0)
    #endif /* USE_FULL_ASSERT */
   ```
   
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to