apache-mynewt-bot commented on issue #2233: [RFC] Fix console echo handling URL: https://github.com/apache/mynewt-core/pull/2233#issuecomment-599595588 <!-- style-bot --> ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md) #### sys/console/minimal/src/console.c <details> ```diff @@ -323,7 +323,7 @@ ev = NULL; console_is_interactive = echo; return 0; - /* Ignore characters if there's no more buffer space */ + /* Ignore characters if there's no more buffer space */ } else if (byte == CONSOLE_NLIP_PKT_START2) { /* Disable echo to not flood the UART */ console_is_interactive = 0; @@ -352,9 +352,9 @@ #endif default: insert_char(&input->line[cur], byte, end); - /* Falls through. */ + /* Falls through. */ case '\r': - /* Falls through. */ + /* Falls through. */ case '\n': if (byte == '\n' && prev_endl == '\r') { /* handle double end line chars */ ``` </details>
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
