de-nordic commented on issue #72: fs_mgmt: Fix file download for Zephyr URL: https://github.com/apache/mynewt-mcumgr/pull/72#issuecomment-600455674 > > > Looks good to me. > > I assume `CONFIG_FS_MGMT_MAX_OFFSET_LEN` is defined in a zephyr repo? It is implicitly defined by Kconfig menu, basing on selected maximal file size that will be downloadable.  > > Also, just a nit pick - I noticed a few typos in the large comment at the top: MCUGMR_BUF_SZIE, cbod. Oops. Will fix it.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
