prasad-alatkar commented on a change in pull request #777: nimble/host: Clear master and slave states on host reset URL: https://github.com/apache/mynewt-nimble/pull/777#discussion_r397263377
########## File path: nimble/host/src/ble_gap.c ########## @@ -737,6 +737,30 @@ ble_gap_slave_reset_state(uint8_t instance) #endif } +/** + * Clears advertisement and discovery state. This function is necessary + * when the controller loses its active state (e.g. on stack reset). + */ +void +ble_gap_master_slave_reset_state(void) +{ +#if NIMBLE_BLE_ADVERTISE +#if MYNEWT_VAL(BLE_EXT_ADV) + uint8_t i; + + for (i = 0; i < BLE_ADV_INSTANCES; i++) { + ble_gap_slave_reset_state(i); Review comment: Yes, but I thought as we are anyway resetting the host stack, so resetting slave_state should be all right. However I understand, as far as `ble_gap_adv_finished` is concerned, we should only call it when actually active adv instance was there. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services