ccollins476ad commented on a change in pull request #392: Update documentation
for mfg create
URL: https://github.com/apache/mynewt-newt/pull/392#discussion_r401717802
##########
File path: docs/command_list/newt_mfg.rst
##########
@@ -87,16 +87,25 @@ The ``rb_blinky_rsa`` package needs a pkg.yml file. In
addition it is needs a mf
.. code-block:: console
$ more mfgs/rb_blinky_rsa/mfg.yml
- mfg.bootloader: 'targets/rb_boot'
- mfg.images:
- - 'targets/rb_blinky'
+ mfg.bsp: "@apache-mynewt-core/hw/bsp/rb-nano2"
+ mfg.targets:
+ - rb_boot:
+ name: "targets/rb_boot"
+ area: FLASH_AREA_BOOTLOADER
+ offset: 0x0
+ - rb_blinky:
+ name: "targets/rb_blinky"
+ area: FLASH_AREA_IMAGE_0
+ offset: 0x0
+ mfg.meta:
+ area: FLASH_AREA_BOOTLOADER
Build the bootloader and app images.
.. code-block:: console
- $ newt build rb_boot
- $ newt create-image rb_blinky 0.0.1
+ $ newt build rb_boot && newt create-image rb_boot 0.0.1
Review comment:
Assuming `rb_boot` is a boot loader target, that should be `newt build
rb_boot` (rather than `newt create-image rb_boot 0.0.1`).
`create-image` would also work, but it creates an unnecessary `.img` file
with an image header (and it requires you to specify a version number that
doesn't get included anywhere).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
