[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit

[GitBox]

apache-mynewt-bot commented on issue #790: nimble/store: Fix nimble store 
behavior when CCCDs exceed static defined limit
URL: https://github.com/apache/mynewt-nimble/pull/790#issuecomment-610477940
 
 
   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### nimble/host/src/ble_gap.c
   <details>
   
   ```diff
   @@ -5623,8 +5621,7 @@
        }
    
        for (i = 0; i < num_peers; i++) {
   -        if (memcmp(curr_peer, &oldest_peer_id_addr[i], sizeof (ble_addr_t)) 
!= 0)
   -        {
   +        if (memcmp(curr_peer, &oldest_peer_id_addr[i], sizeof (ble_addr_t)) 
!= 0) {
                break;
            }
        }
   ```
   
   </details>
   
   #### nimble/host/src/ble_store_util.c
   <details>
   
   ```diff
   @@ -341,7 +341,7 @@
            key.cccd.peer_addr = peer_cccd_addrs[i];
    
            for (j = 0; j < num_bonded_peers; j++) {
   -            if(memcmp(&peer_cccd_addrs[i], &peer_bonded_addrs[j],
   +            if (memcmp(&peer_cccd_addrs[i], &peer_bonded_addrs[j],
                          sizeof(ble_addr_t)) == 0) {
                    break;
                }
   @@ -385,7 +385,7 @@
            case BLE_STORE_OBJ_TYPE_CCCD:
                /* Try to remove unbonded CCCDs first */
                if ((rc = ble_store_clean_old_cccds((void *) 
&event->overflow.value->cccd.peer_addr))
   -                 == BLE_HS_ENOENT) {
   +                == BLE_HS_ENOENT) {
                    /* No unbonded CCCDs found to delete, try unpairing oldest 
peer
                     * except current peer */
                    return ble_gap_unpair_oldest_except_curr((void *) 
&event->overflow.value->cccd.peer_addr);
   ```
   
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services