rymanluk commented on a change in pull request #790: nimble/store: Fix nimble
store behavior when CCCDs exceed static defined limit
URL: https://github.com/apache/mynewt-nimble/pull/790#discussion_r407949256
##########
File path: nimble/host/src/ble_store_util.c
##########
@@ -230,16 +372,24 @@ ble_store_util_delete_oldest_peer(void)
int
ble_store_util_status_rr(struct ble_store_status_event *event, void *arg)
{
+ int rc = BLE_HS_EUNKNOWN;
switch (event->event_code) {
case BLE_STORE_EVENT_OVERFLOW:
switch (event->overflow.obj_type) {
- case BLE_STORE_OBJ_TYPE_OUR_SEC:
- case BLE_STORE_OBJ_TYPE_PEER_SEC:
- case BLE_STORE_OBJ_TYPE_CCCD:
- return ble_gap_unpair_oldest_peer();
-
- default:
- return BLE_HS_EUNKNOWN;
+ case BLE_STORE_OBJ_TYPE_OUR_SEC:
+ case BLE_STORE_OBJ_TYPE_PEER_SEC:
+ return ble_gap_unpair_oldest_peer();
+ case BLE_STORE_OBJ_TYPE_CCCD:
+ /* Try to remove unbonded CCCDs first */
+ if ((rc = ble_store_clean_old_cccds((void *)
&event->overflow.value->cccd.peer_addr)) == BLE_HS_ENOENT) {
Review comment:
@h2zero actually CCCD's do get stored when devices are bonded. That happens
after pairing is completed and both devices have bonding flag in set.
If you do see an issue that CCCDs are stored but device is not actually
bonded, please report it as an issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
