rymanluk commented on a change in pull request #796: Apps: central added URL: https://github.com/apache/mynewt-nimble/pull/796#discussion_r410024995
########## File path: nimble/host/include/host/ble_gap.h ########## @@ -1984,6 +1984,8 @@ int ble_gap_set_prefered_default_le_phy(uint8_t tx_phys_mask, * - BLE_GAP_LE_PHY_CODED_S8 * * @return 0 on success; nonzero on failure. + * + * When PHY is successfully changed, phy_updated event is occurs. Review comment: This could go up to the function description. We can even say what even exactly which is BLE_GAP_EVENT_PHY_UPDATE_COMPLETE. Also this should go as separate patch ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
