nkaje commented on a change in pull request #162:
URL: https://github.com/apache/mynewt-newtmgr/pull/162#discussion_r426317891



##########
File path: nmxact/xact/image.go
##########
@@ -185,33 +204,149 @@ func nextImageUploadReq(s sesn.Sesn, upgrade bool, data 
[]byte, off int, imageNu
        return r, nil
 }
 
-func (c *ImageUploadCmd) Run(s sesn.Sesn) (Result, error) {
-       res := newImageUploadResult()
+func (t *ImageUploadIntTracker) update(t_off int, r_off int, status int) {

Review comment:
       I "feel" that there could be a possibility that the offsets in responses 
repeat e.g 0, 357, 357, 357, 750, 1120 etc. Hence keeping the count in the maps 
around for now. Based on more testing, we can potentially get rid of it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to