apache-mynewt-bot removed a comment on pull request #2286: URL: https://github.com/apache/mynewt-core/pull/2286#issuecomment-633530374
<!-- style-bot --> ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md) #### apps/bleprph_memfault/src/gatt_svr.c <details> ```diff @@ -31,13 +31,13 @@ switch (ctxt->op) { case BLE_GATT_REGISTER_OP_SVC: - DFLT_LOG_DEBUG("registered service %s with handle=%d\n", + DFLT_LOG_DEBUG("registered service %s with handle=%d\n", ble_uuid_to_str(ctxt->svc.svc_def->uuid, buf), ctxt->svc.handle); break; case BLE_GATT_REGISTER_OP_CHR: - DFLT_LOG_DEBUG("registering characteristic %s with " + DFLT_LOG_DEBUG("registering characteristic %s with " "def_handle=%d val_handle=%d\n", ble_uuid_to_str(ctxt->chr.chr_def->uuid, buf), ctxt->chr.def_handle, @@ -45,7 +45,7 @@ break; case BLE_GATT_REGISTER_OP_DSC: - DFLT_LOG_DEBUG("registering descriptor %s with handle=%d\n", + DFLT_LOG_DEBUG("registering descriptor %s with handle=%d\n", ble_uuid_to_str(ctxt->dsc.dsc_def->uuid, buf), ctxt->dsc.handle); break; ``` </details> #### apps/bleprph_memfault/src/main.c <details> ```diff @@ -58,7 +58,8 @@ }; void -memfault_metrics_heartbeat_collect_data(void) { +memfault_metrics_heartbeat_collect_data(void) +{ struct os_task *prev_task; struct os_task_info oti; char *name; ``` </details> #### sys/memfault/src/memfault_platform_core.c <details> ```diff @@ -69,7 +69,7 @@ metrics_period_sec = period_sec; metrics_callback = callback; metrics_callout_cb(NULL); - return true; // indicates setup was successful + return true; /* indicates setup was successful */ } uint64_t @@ -94,27 +94,31 @@ }; memfault_reboot_tracking_boot(s_reboot_tracking, &reset_reason); - // Note: MCU reset reason register bits are usually "sticky" and - // need to be cleared + /* + Note: MCU reset reason register bits are usually "sticky" and + need to be cleared + */ NRF_POWER->RESETREAS |= NRF_POWER->RESETREAS; const sMemfaultEventStorageImpl *evt_storage = memfault_events_storage_boot(s_event_storage, sizeof(s_event_storage)); - // Pass the storage to collect reset info + /* Pass the storage to collect reset info */ memfault_reboot_tracking_collect_reset_info(evt_storage); - // Pass the storage to initialize the trace event module + /* Pass the storage to initialize the trace event module */ memfault_trace_event_boot(evt_storage); - // NOTE: crash count represents the number of unexpected reboots since the - // last heartbeat was reported. In the simplest case if reboots are - // unexpected, this can just be set to 1 but see memfault/metrics/metrics.h - // how this can be tracked with the reboot_tracking module. + /* + NOTE: crash count represents the number of unexpected reboots since the + last heartbeat was reported. In the simplest case if reboots are + unexpected, this can just be set to 1 but see memfault/metrics/metrics.h + how this can be tracked with the reboot_tracking module. + */ sMemfaultMetricBootInfo boot_info = { .unexpected_reboot_count = memfault_reboot_tracking_get_crash_count() }; rc = memfault_metrics_boot(evt_storage, &boot_info); - // NOTE: a non-zero value indicates a configuration error took place + /* NOTE: a non-zero value indicates a configuration error took place */ SYSINIT_PANIC_ASSERT(rc == 0); memfault_reboot_tracking_reset_crash_count(); ``` </details> #### sys/memfault/src/memfault_platform_flash_backed_coredump.c <details> ```diff @@ -32,8 +32,7 @@ const sMfltCoredumpRegion * -memfault_platform_coredump_get_regions( - const sCoredumpCrashInfo *crash_info, size_t *num_regions) +memfault_platform_coredump_get_regions(const sCoredumpCrashInfo *crash_info, size_t *num_regions) { static sMfltCoredumpRegion s_coredump_regions[1]; int area_cnt; ``` </details> ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
