[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2294: mbedtls_aes_alt: add setkey for decyption, validate input, fix data type and return type

[GitBox]

apache-mynewt-bot removed a comment on pull request #2294:
URL: https://github.com/apache/mynewt-core/pull/2294#issuecomment-634662800


   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### hw/drivers/crypto/include/crypto/aes_alt.h
   <details>
   
   ```diff
   @@ -30,8 +30,7 @@
    
    #include <crypto/crypto.h>
    
   -typedef struct mbedtls_aes_context
   -{
   +typedef struct mbedtls_aes_context {
        struct crypto_dev *crypto;
        uint8_t key[AES_MAX_KEY_LEN];
        unsigned int keylen;
   ```
   
   </details>
   
   #### hw/drivers/crypto/src/mbedtls_aes_alt.c
   <details>
   
   ```diff
   @@ -43,7 +43,7 @@
    
    int
    mbedtls_aes_setkey(mbedtls_aes_context *ctx, const unsigned char *key,
   -        unsigned int keybits)
   +                   unsigned int keybits)
    {
        switch (keybits) {
        case AES_128_KEY_LEN * 8:
   @@ -59,7 +59,7 @@
    
    int
    mbedtls_aes_validate_input(mbedtls_aes_context *ctx, const unsigned char 
*key,
   -        unsigned int keybits)
   +                           unsigned int keybits)
    {
        assert(ctx);
    
   @@ -72,7 +72,7 @@
    
    int
    mbedtls_aes_setkey_enc(mbedtls_aes_context *ctx, const unsigned char *key,
   -        unsigned int keybits)
   +                       unsigned int keybits)
    {
        int ret = mbedtls_aes_validate_input(ctx, key, keybits);
    
   @@ -85,7 +85,7 @@
    
    int
    mbedtls_aes_setkey_dec(mbedtls_aes_context *ctx, const unsigned char *key,
   -        unsigned int keybits)
   +                       unsigned int keybits)
    {
        int ret = mbedtls_aes_validate_input(ctx, key, keybits);
    
   @@ -98,10 +98,10 @@
    
    int
    mbedtls_aes_crypt_ecb(mbedtls_aes_context *ctx, int mode,
   -        const unsigned char input[16], unsigned char output[16])
   +                      const unsigned char input[16], unsigned char 
output[16])
    {
        int ret = crypto_encrypt_aes_ecb(ctx->crypto, ctx->key, ctx->keylen,
   -            (const uint8_t *)input, (uint8_t *)output, AES_BLOCK_LEN);
   +                                     (const uint8_t *)input, (uint8_t 
*)output, AES_BLOCK_LEN);
        if (ret == AES_BLOCK_LEN) {
            return 0;
        } else {
   ```
   
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org