ccollins476ad commented on a change in pull request #2300: URL: https://github.com/apache/mynewt-core/pull/2300#discussion_r432625138
########## File path: net/oic/src/port/mynewt/stream.c ########## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/** + * stream.c: Utility code for adaptors that implement the CoAP-over-TCP + * protocol (Bluetooth, TCP/IP, etc.). + */ + +#include "os/mynewt.h" +#include "oic/port/mynewt/stream.h" +#include "oic/messaging/coap/coap.h" + +int +oc_stream_reass(struct oc_stream_reassembler *r, struct os_mbuf *om1, + void *ep_desc, struct os_mbuf **out_pkt) +{ + struct os_mbuf_pkthdr *pkt1; + struct os_mbuf_pkthdr *pkt2; + struct os_mbuf *om2; + uint8_t hdr[sizeof (struct coap_tcp_hdr32)]; Review comment: Thanks, I have fixed this (and the other style issues you identified). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
