utzig commented on a change in pull request #2327:
URL: https://github.com/apache/mynewt-core/pull/2327#discussion_r452969381
##########
File path: hw/mcu/dialog/include/DA1469xAB.h
##########
@@ -8588,6 +8588,16 @@ typedef struct { /*!< (@
0x50000100) WAKEUP Struc
/** @} */ /* End of group PosMask_peripherals */
+/* Definitions for REMAP_ADR0 (bits 2:0) of SYS_CTRL_REG. See Datasheet for
details */
Review comment:
The header says:
```
* @file DA1469xAB.h
* @brief CMSIS HeaderFile
* @version 1.2
* @date 28. March 2019
* @note Generated by SVDConv V3.3.25 on Thursday, 28.03.2019 17:24:46
* from File 'DA1469x.xml',
```
I've no idea if this file is ever gonna be re-generated, in which case
modifying it wouldn't be so great. Maybe it would be better to just define this
inside the crypto driver itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
