[GitHub] [mynewt-nimble] andrzej-kaczmarek commented on a change in pull request #843: nimble/porting: Replace strncpy with strlcpy to NULL terminate string buffer

[GitBox]

andrzej-kaczmarek commented on a change in pull request #843:
URL: https://github.com/apache/mynewt-nimble/pull/843#discussion_r453648620



##########
File path: porting/nimble/src/os_mempool.c
##########
@@ -336,7 +336,7 @@ os_mempool_info_get_next(struct os_mempool *mp, struct 
os_mempool_info *omi)
     omi->omi_num_blocks = cur->mp_num_blocks;
     omi->omi_num_free = cur->mp_num_free;
     omi->omi_min_free = cur->mp_min_free;
-    strncpy(omi->omi_name, cur->name, sizeof(omi->omi_name));
+    strlcpy(omi->omi_name, cur->name, sizeof(omi->omi_name));

Review comment:
       `strlcpy` is not a standard library function so keep `strncpy` and 
terminate manually instead




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org