kasjer commented on a change in pull request #2355:
URL: https://github.com/apache/mynewt-core/pull/2355#discussion_r471677199
##########
File path: hw/sensor/include/sensor/current.h
##########
@@ -0,0 +1,25 @@
+#ifndef __SENSOR_CURRENT_H__
+#define __SENSOR_CURRENT_H__
+
+#include "os/mynewt.h"
+#include "sensor/sensor.h"
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+/* Data representing a singular read from a pressure sensor
Review comment:
It should not be **pressure** but current I suppose.
##########
File path: hw/sensor/include/sensor/voltage.h
##########
@@ -0,0 +1,25 @@
+#ifndef __SENSOR_VOLTAGE_H__
+#define __SENSOR_VOLTAGE_H__
+
+#include "os/mynewt.h"
+#include "sensor/sensor.h"
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+/* Data representing a singular read from a pressure sensor
Review comment:
Change pressure to voltage please.
##########
File path: hw/sensor/include/sensor/voltage.h
##########
@@ -0,0 +1,25 @@
+#ifndef __SENSOR_VOLTAGE_H__
+#define __SENSOR_VOLTAGE_H__
+
+#include "os/mynewt.h"
+#include "sensor/sensor.h"
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+/* Data representing a singular read from a pressure sensor
+ * All values are in V
+ */
+struct sensor_voltage_data {
+ float svd_voltage;
+
+ /* Validity */
+ uint8_t svd_voltage_is_valid:1;
+};
+
+#ifdef __cplusplus
+}
+#endif
+
+#endif /* __VOLTAGE_HUMIDITY_H__ */
Review comment:
It should be __SENSOR_VOLTAGE_H__
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
