utzig commented on a change in pull request #2362: URL: https://github.com/apache/mynewt-core/pull/2362#discussion_r476924389
########## File path: apps/rust_blinky/src/lib.rs ########## @@ -0,0 +1,54 @@ +/* + * Copyright 2020 Casper Meijn <[email protected]> + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#![no_std] + +mod bindings; + +extern crate panic_halt; + +// Define a safe wrapper for os_time_delay +fn os_time_delay_ms(ms: u32) { + let mut ticks: bindings::os_time_t = 0; + let result = unsafe { bindings::os_time_ms_to_ticks(ms, &mut ticks) }; + assert!(result == 0); + unsafe { bindings::os_time_delay(ticks) }; +} + +#[no_mangle] +pub extern "C" fn main() { + /* Initialize all packages. */ + unsafe { + bindings::sysinit_start(); + bindings::sysinit_app(); + bindings::sysinit_end(); + } + + /* Turn on the LED */ + unsafe { + bindings::hal_gpio_init_out(bindings::LED_BLINK_PIN as i32, 1); Review comment: `LED_BLINK_PIN` is usually a #define in `bsp/bsp.h`, does bindgen generate a binding for it? ########## File path: apps/rust_blinky/build.rs ########## @@ -0,0 +1,70 @@ +/* + * SPDX-License-Identifier: Apache-2.0 + * Copyright 2020 Casper Meijn <[email protected]> + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +extern crate bindgen; + +use std::env; +use std::path::PathBuf; +use std::process::Command; +use std::str; + +fn main() { + let out_path = PathBuf::from(env::var("OUT_DIR").unwrap()).join("bindings.rs"); + + let mut builder = bindgen::Builder::default() + .clang_arg("--target=thumbv7m-none-eabi") Review comment: Is this needed? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
