caspermeijn opened a new pull request #2387: URL: https://github.com/apache/mynewt-core/pull/2387
The return code of succesfull log_cbmem_walk was 0, even when the loop ended early. In case of an early loop break, we want to return the rc of the walked function. This is needed to make `newtmgr log show --all` work, as the rc is passed to the client to indicate more data available. The return codes of the log_walk functions seem a bit of a mess, as they both indicate an error state as rc of the walk_func. To bad C doesn't support multiple return values. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
