benmccrea commented on a change in pull request #2392:
URL: https://github.com/apache/mynewt-core/pull/2392#discussion_r507182931
##########
File path: hw/drivers/crypto/crypto_da1469x/src/crypto_da1469x.c
##########
@@ -73,7 +74,10 @@ do_dma_key_tx(const void *key, uint16_t keylen)
da1469x_otp_set_mode(OTPC_MODE_READ);
/* securely DMA hardware key from secret storage to QSPI decrypt engine */
- dma_regs->DMA_REQ_MUX_REG |= 0xf000;
+ OS_ENTER_CRITICAL(sr);
+ /* Use the secure channel #7 */
+ MCU_DMA_SET_MUX(7, MCU_DMA_PERIPH_NONE);
Review comment:
@agross-korg I agree, the macro needs fixed. It might be better to have
separate macros for single-channel and channel-pair (peripheral) use, where
`da1469x_dma_acquire_single()` would use the single-channel version and
`da1469x_dma_acquire_periph()` would use the channel-pair version.
BTW - the driver does support channels 8-15 by setting MCU_DMA_CHAN_MAX > 8,
but only channels 0-7 are defined (in hardware) by `DMA_REQ_MUX_REG`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
