benmccrea commented on a change in pull request #2395:
URL: https://github.com/apache/mynewt-core/pull/2395#discussion_r510923764
##########
File path: hw/mcu/dialog/da1469x/src/hal_gpio.c
##########
@@ -473,6 +474,10 @@ mcu_gpio_enter_sleep(void)
return;
}
+ /* Save pins states and their latched values */
Review comment:
@JustineKH Are interrupts already disabled when `mcu_gpio_enter_sleep`
gets called? If not, an interrupt could change pin levels before entering
sleep.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
