apache-mynewt-bot commented on pull request #2433: URL: https://github.com/apache/mynewt-core/pull/2433#issuecomment-742549893
<!-- style-bot --> ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md) #### hw/util/button/src/button.c <details> ```diff @@ -361,13 +368,13 @@ #endif } - do_assert: +do_assert: assert(0); - - do_nothing: - return; - - do_pressed: + +do_nothing: + return; + +do_pressed: #if MYNEWT_VAL(BUTTON_USE_LONG) if (button->mode & BUTTON_FLG_LONG) { os_callout_reset(callout, os_time_ms_to_ticks32(MYNEWT_VAL(BUTTON_LONGHOLD_TIME_MS))); @@ -388,14 +395,14 @@ #endif button->fsm_state = _BUTTON_FSM_PRESSED; return; - + #if MYNEWT_VAL(BUTTON_USE_DOUBLE) - to_wait_dblpressed: + to_wait_dblpressed : os_callout_reset(callout, os_time_ms_to_ticks32(MYNEWT_VAL(BUTTON_DBLCLICK_TIMEOUT_MS))); button->fsm_state = _BUTTON_FSM_WAIT_DBLPRESSED; return; - - do_dblpressed: + +do_dblpressed: #if MYNEWT_VAL(BUTTON_USE_LONG) if (button->mode & BUTTON_FLG_LONG) { os_callout_reset(callout, os_time_ms_to_ticks32(MYNEWT_VAL(BUTTON_LONGHOLD_TIME_MS))); @@ -405,7 +412,7 @@ #endif } else { os_callout_stop(callout); - } + } #elif MYNEWT_VAL(BUTTON_USE_REPEAT) os_callout_reset(callout, os_time_ms_to_ticks32(MYNEWT_VAL(BUTTON_REPEAT_FIRST_TIME_MS))); #else @@ -420,10 +427,11 @@ #endif #if MYNEWT_VAL(BUTTON_USE_LONG) - do_longpress: -#if MYNEWT_VAL(BUTTON_USE_REPEAT) - if (button->mode & BUTTON_FLG_REPEATING) + do_longpress : +#if MYNEWT_VAL(BUTTON_USE_REPEAT) + if (button->mode & BUTTON_FLG_REPEATING) { os_callout_reset(callout, os_time_ms_to_ticks32(MYNEWT_VAL(BUTTON_REPEAT_FIRST_TIME_MS))); + } #endif button->state |= BUTTON_FLG_LONG; #if MYNEWT_VAL(BUTTON_EMIT_STATE_CHANGED) @@ -432,18 +440,18 @@ button->fsm_state = _BUTTON_FSM_HOLD_OR_REPEAT; return; #endif - -#if MYNEWT_VAL(BUTTON_USE_REPEAT) - do_repeat: + +#if MYNEWT_VAL(BUTTON_USE_REPEAT) + do_repeat : os_callout_reset(callout, os_time_ms_to_ticks32(MYNEWT_VAL(BUTTON_REPEAT_TIME_MS))); - + #if MYNEWT_VAL(BUTTON_EMIT_ACTION) #if MYNEWT_VAL(BUTTON_USE_EMULATION) if (!button_stealed_action(button)) #endif - BUTTON_POST_ACTION_EVENT(button, button->state); -#endif - + BUTTON_POST_ACTION_EVENT(button, button->state); +#endif + if (!(button->state & BUTTON_FLG_REPEATING)) { button->state |= BUTTON_FLG_REPEATING; #if MYNEWT_VAL(BUTTON_EMIT_STATE_CHANGED) ``` </details> ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
