apache-mynewt-bot commented on pull request #931:
URL: https://github.com/apache/mynewt-nimble/pull/931#issuecomment-795200415


   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### nimble/controller/include/controller/ble_ll_scan.h
   <details>
   
   ```diff
   @@ -79,8 +79,7 @@
        uint32_t start_time;
    };
    
   -struct ble_ll_scan_phy
   -{
   +struct ble_ll_scan_phy {
        uint8_t configured;
        uint8_t phy;
        uint8_t scan_type;
   @@ -148,8 +147,7 @@
        uint8_t adva[BLE_DEV_ADDR_LEN];
    };
    
   -struct ble_ll_scan_sm
   -{
   +struct ble_ll_scan_sm {
        uint8_t scan_enabled;
    
        uint8_t own_addr_type;
   ```
   
   </details>
   
   #### nimble/controller/src/ble_ll_scan.c
   <details>
   
   ```diff
   @@ -1224,7 +1224,7 @@
        TAILQ_INIT(&g_scan_dup_list);
    
        if ((BLE_LL_SCAN_NUM_PHYS > 1) && scansm->scan_phys[0].configured &&
   -                                      scansm->scan_phys[1].configured) {
   +        scansm->scan_phys[1].configured) {
            scanp_0 = &scansm->scan_phys[0];
            scanp_1 = &scansm->scan_phys[1];
    
   @@ -3377,8 +3377,8 @@
         */
        if (!(cmd->phys & SCAN_VALID_PHY_MASK) ||
            (cmd->phys & ~SCAN_VALID_PHY_MASK)) {
   -         return BLE_ERR_INV_HCI_CMD_PARMS;
   -     }
   +        return BLE_ERR_INV_HCI_CMD_PARMS;
   +    }
    
        scanp = &scan_phys_new[0];
    
   @@ -3852,9 +3854,9 @@
        scanp->phy = BLE_PHY_1M;
        scanp->scan_type = BLE_SCAN_TYPE_PASSIVE;
        scanp->timing.interval =
   -                ble_ll_scan_time_hci_to_ticks(BLE_HCI_SCAN_ITVL_DEF);
   +        ble_ll_scan_time_hci_to_ticks(BLE_HCI_SCAN_ITVL_DEF);
        scanp->timing.window =
   -                ble_ll_scan_time_hci_to_ticks(BLE_HCI_SCAN_WINDOW_DEF);
   +        ble_ll_scan_time_hci_to_ticks(BLE_HCI_SCAN_WINDOW_DEF);
    
    #if BLE_LL_SCAN_NUM_PHYS > 1
        scanp = &g_ble_ll_scan_params.scan_phys[1];
   ```
   
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to