utzig commented on a change in pull request #2530:
URL: https://github.com/apache/mynewt-core/pull/2530#discussion_r594551372
##########
File path: hw/mcu/sifive/fe310/src/hal_timer.c
##########
@@ -169,9 +182,9 @@ int
hal_timer_init(int timer_num, void *cfg)
{
struct fe310_hal_tmr *tmr;
+ (void)cfg;
- if (timer_num >= FE310_HAL_TIMER_MAX || !(tmr = fe310_tmr_devs[timer_num])
||
- (cfg == NULL)) {
+ if (timer_num >= FE310_HAL_TIMER_MAX || !(tmr =
fe310_tmr_devs[timer_num])) {
Review comment:
Why do you need to set `tmr` if it's not being used?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
