utzig commented on a change in pull request #2531:
URL: https://github.com/apache/mynewt-core/pull/2531#discussion_r594647034
##########
File path: hw/bsp/black_vet6/src/hal_bsp.c
##########
@@ -261,14 +261,15 @@ const struct stm32_eth_cfg os_bsp_eth0_cfg = {
.sec_port_mask[2] = (1 << 1) | (1 << 4) | (1 << 5),
/*
- * PORTG
- * PG11 - ETH_RMII_TXEN
- * PG13 - ETH_RMII_TXD0
- * PG14 - ETH_RMII_TXD1
+ * PORTB
+ * PB11 - ETH_RMII_TXEN
+ * PB12 - ETH_RMII_TXD0
+ * PB13 - ETH_RMII_TXD1
*/
- .sec_port_mask[6] = (1 << 11) | (1 << 13) | (1 << 14),
- .sec_phy_type = SMSC_8710_RMII,
- .sec_phy_irq = MCU_GPIO_PORTA(3)
+ .sec_port_mask[1] = (1 << 11) | (1 << 12) | (1 << 13),
+ .sec_phy_type = MYNEWT_VAL(STM32_ETH_PHY_TYPE),
+ .sec_phy_irq = MYNEWT_VAL(STM32_ETH_PHY_IRQ)
Review comment:
oh, there is a missing `,` here, nicely caught by the style checker
(without knowing it!).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
