vrahane commented on a change in pull request #2611:
URL: https://github.com/apache/mynewt-core/pull/2611#discussion_r644776652
##########
File path: hw/drivers/ram/spiram/src/spiram.c
##########
@@ -102,7 +102,7 @@ spiram_write_enable(struct spiram_dev *dev)
int
spiram_read(struct spiram_dev *dev, uint32_t addr, void *buf, uint32_t size)
{
- uint8_t cmd[5] = { SPIRAM_READ };
+ uint8_t cmd[6] = { SPIRAM_READ };
Review comment:
Does it make sense to break the limit down into 3/4 byte addressing +
max command length or something ?
##########
File path: hw/drivers/ram/spiram/src/spiram.c
##########
@@ -102,7 +102,7 @@ spiram_write_enable(struct spiram_dev *dev)
int
spiram_read(struct spiram_dev *dev, uint32_t addr, void *buf, uint32_t size)
{
- uint8_t cmd[5] = { SPIRAM_READ };
+ uint8_t cmd[6] = { SPIRAM_READ };
Review comment:
Does it make sense to break the limit down into 3/4 byte addressing +
max command length or something ? I mean a syscfg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
