ncasaril commented on a change in pull request #944:
URL: https://github.com/apache/mynewt-nimble/pull/944#discussion_r662044331
##########
File path: nimble/include/nimble/ble.h
##########
@@ -109,9 +109,9 @@ struct ble_mbuf_hdr_rxinfo
struct ble_mbuf_hdr_txinfo
{
uint8_t flags;
- uint8_t offset;
- uint8_t pyld_len;
uint8_t hdr_byte;
+ uint16_t offset;
+ uint16_t pyld_len;
Review comment:
Changing the types to uint16_t here breaks larger replies from a
peripheral. For instance listing the images using newtmgr with two images
present on the peripheral. Changing the types back to uint8_t makes it work.
Adding a dummy byte before the offset / pyld_len breaks download again. I.e.:
```
/* This works */
struct ble_mbuf_hdr_txinfo
{
uint8_t flags;
uint8_t offset;
uint8_t pyld_len;
uint8_t hdr_byte;
};
```
```
/* This doesn't work */
struct ble_mbuf_hdr_txinfo
{
uint8_t flags;
uint8_t offset;
uint8_t dummy;
uint8_t pyld_len;
uint8_t hdr_byte;
};
```
Is anyone else seeing this? @andrzej-kaczmarek
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
