sjanc commented on a change in pull request #987:
URL: https://github.com/apache/mynewt-nimble/pull/987#discussion_r664324471
##########
File path: nimble/host/src/ble_l2cap_sig.c
##########
@@ -1979,6 +1979,9 @@ ble_l2cap_sig_ping(uint16_t conn_handle,
ble_l2cap_ping_fn cb,
rc = ble_l2cap_sig_tx(proc->conn_handle, txom);
+ if (rc != 0) {
Review comment:
hmm but then, ble_l2cap_tx will consume txom even on error
maybe ble_l2cap_sig_tx() should be updated to always consume txom, btw I
think ble_sm_tx() has same issue
I'll try to lo review those code parts this week and propose some unified
solution
##########
File path: nimble/host/src/ble_l2cap_sig.c
##########
@@ -1979,6 +1979,9 @@ ble_l2cap_sig_ping(uint16_t conn_handle,
ble_l2cap_ping_fn cb,
rc = ble_l2cap_sig_tx(proc->conn_handle, txom);
+ if (rc != 0) {
Review comment:
hmm but then, ble_l2cap_tx will consume txom even on error
maybe ble_l2cap_sig_tx() should be updated to always consume txom, btw I
think ble_sm_tx() has same issue
I'll try to review those code parts this week and propose some unified
solution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
