t3zeng commented on a change in pull request #2686:
URL: https://github.com/apache/mynewt-core/pull/2686#discussion_r714802540



##########
File path: kernel/os/syscfg.yml
##########
@@ -190,6 +195,9 @@ syscfg.defs:
             If set, run time is measured in cpu time ticks rather than OS time
             ticks.
         value: 0
+    MEMFAULT_ENABLE:
+        description: 'Enables Memfault SDK features'

Review comment:
       util/memfault_sdk is currently only included inside `kernel/os/pkg.yml` 
if `MEMFAULT_ENABLE` is set. Putting `MEMFAULT_ENABLE` inside 
`util/memfault_sdk/syscfg.yml` would create a catch-22 circular dependency




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to