andrzej-kaczmarek commented on pull request #2686: URL: https://github.com/apache/mynewt-core/pull/2686#issuecomment-938551010
There's no need to add `util/memfault_sdk` package to your repository, you just need to add `os_coredump_cb` and `os_assert_cb` definitions to already existing `ports/mynewt` - it's that simple. I checked few other ports available in Memfault repository and they seem to require some kind of patching in target OS (e.g. FreeRTOS, Zephyr, Dialog SDK) since there's no support provided by those OSes, so I do not understand why you guys push on adding code to Mynewt so much and claim that Mynewt will be _"less attractive (...) in comparison to some other RTOS that does include support"_. In fact, in case of Mynewt all you have to do is to tweak app/target configuration, no need to apply any patches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
