sjanc commented on a change in pull request #1065:
URL: https://github.com/apache/mynewt-nimble/pull/1065#discussion_r739223903
##########
File path: nimble/host/src/ble_gap.c
##########
@@ -1294,14 +1294,12 @@ ble_gap_master_in_progress(void)
#endif
}
-#if NIMBLE_BLE_ADVERTISE || NIMBLE_BLE_CONNECT
-static int
+int
ble_gap_adv_active_instance(uint8_t instance)
{
/* Assume read is atomic; mutex not necessary. */
Review comment:
other functions typically use BLE_HS_EINVAL for such cases, lets keep it
consistent (note no minus)
other than that looks OK to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
