KKopyscinski commented on a change in pull request #1111:
URL: https://github.com/apache/mynewt-nimble/pull/1111#discussion_r759427011
##########
File path: nimble/host/mesh/include/mesh/glue.h
##########
@@ -566,8 +566,12 @@ static inline void k_sem_init(struct k_sem *sem, unsigned
int initial_count,
static inline int k_sem_take(struct k_sem *sem, int32_t timeout)
{
uint32_t ticks;
+ int rc;
- ble_npl_time_ms_to_ticks(timeout, &ticks);
+ rc = ble_npl_time_ms_to_ticks(timeout, &ticks);
+ if (rc) {
+ assert(0);
Review comment:
I think we can, as this function return `int` - I looked at how it is
handled elsewhere and for example `k_work_schedule` is using assert, but I
guess because it returns `void`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
