vrahane commented on a change in pull request #2762:
URL: https://github.com/apache/mynewt-core/pull/2762#discussion_r799502179
##########
File path: hw/scripts/common.sh
##########
@@ -88,6 +88,14 @@ detect_programmer() {
# extract the VID:PID list for connected USB devices
USB_DEV=$(lsusb | cut -f6 -d' ')
+ elif [ $(which system_profiler) ] ; then
+
+ # extract the VID:PID list for connected USB devices on OSX
+ USB_DEV=$(system_profiler SPUSBDataType 2>/dev/null | awk '/^[
\t]+Product ID:/ { PID=$3 } /^[ \t]+Vendor ID:/ { printf("%s:%s\n", PID, $3) }')
Review comment:
Either reformatting or using smaller consecutive statements, both are
fine as long as it’s smaller. 151 characters in one line is not really a good
practice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
