sjanc commented on code in PR #1224:
URL: https://github.com/apache/mynewt-nimble/pull/1224#discussion_r843911890
##########
nimble/host/include/host/ble_gap.h:
##########
@@ -973,6 +975,21 @@ struct ble_gap_event {
uint8_t adv_clk_accuracy;
} periodic_transfer;
#endif
+ struct {
Review Comment:
please comments those events and its members as we have for other events
##########
nimble/host/include/host/ble_gap.h:
##########
@@ -2097,6 +2114,20 @@ int ble_gap_event_listener_register(struct
ble_gap_event_listener *listener,
*/
int ble_gap_event_listener_unregister(struct ble_gap_event_listener *listener);
+int ble_gap_set_path_loss_reporting_enable(uint16_t conn_handle, uint8_t
enable);
Review Comment:
public API should be documented with doxygen
##########
nimble/host/include/host/ble_gap.h:
##########
@@ -2097,6 +2114,20 @@ int ble_gap_event_listener_register(struct
ble_gap_event_listener *listener,
*/
int ble_gap_event_listener_unregister(struct ble_gap_event_listener *listener);
+int ble_gap_set_path_loss_reporting_enable(uint16_t conn_handle, uint8_t
enable);
+
+int ble_gap_set_transmit_power_reporting_enable(uint16_t conn_handle,
+ uint8_t local_enable,
Review Comment:
some indentation issues here (and functions below too)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
