[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2846: sensors/bmp388: Add compatibility for bmp390

[GitBox]

apache-mynewt-bot commented on PR #2846:
URL: https://github.com/apache/mynewt-core/pull/2846#issuecomment-1148144144

   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is 
[here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### hw/drivers/sensors/bmp388/src/bmp388.c
   <details>
   
   ```diff
   @@ -3435,24 +3468,24 @@
            }
    
            rc = bmp3_fifo_flush(&bmp388->bmp3_dev);
   -        if(rc) {
   +        if (rc) {
                BMP388_LOG_ERROR("fifo flush failed, error=0x%02x\n", rc);
                goto error;
            }
    
            rc = bmp388_set_fifo_cfg(bmp388, cfg->fifo_mode, 
cfg->fifo_threshold);
   -        if(rc) {
   +        if (rc) {
                BMP388_LOG_ERROR("set fifo failed, error=0x%02x\n", rc);
                goto error;
            }
    #if MYNEWT_VAL(BMP388_INT_ENABLE)
            rc = bmp388_set_int_enable(bmp388, 1, 
bmp388->cfg.read_mode.int_type);
   -        if(rc) {
   +        if (rc) {
                BMP388_LOG_ERROR("set int enable failed, error=0x%02x\n", rc);
                goto error;
            }
            rc = bmp388_clear_int(bmp388);
   -        if(rc) {
   +        if (rc) {
                BMP388_LOG_ERROR("clear int failed, error=0x%02x\n", rc);
                goto error;
            }
   @@ -3536,10 +3569,10 @@
    #endif
            frame_length = fifo.data.parsed_frames;
    
   -        for(i = 0; i < frame_length; i++) {
   +        for (i = 0; i < frame_length; i++) {
                rc = bmp388_do_report(sensor, sensor_type, read_func, read_arg, 
&sensor_data[i]);
    
   -            if(rc) {
   +            if (rc) {
                    BMP388_LOG_ERROR("*****BMP388_DO_REPORT FAILED %d\n", rc);
                    goto error;
                }
   @@ -3560,12 +3593,12 @@
            do {
                rc = bmp3_get_status(&bmp388->bmp3_dev);
    #if MYNEWT_VAL(BMP388_INT_ENABLE)
   -            if(bmp388->bmp3_dev.status.intr.drdy) {
   +            if (bmp388->bmp3_dev.status.intr.drdy) {
                    break;
                }
    #else
   -            if((bmp388->bmp3_dev.status.sensor.drdy_press) &&
   -                    (bmp388->bmp3_dev.status.sensor.drdy_temp)) {
   +            if ((bmp388->bmp3_dev.status.sensor.drdy_press) &&
   +                (bmp388->bmp3_dev.status.sensor.drdy_temp)) {
                    break;
                }
    #endif
   ```
   
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org