agross-korg commented on code in PR #2885:
URL: https://github.com/apache/mynewt-core/pull/2885#discussion_r981515773
##########
hw/mcu/dialog/da1469x/syscfg.yml:
##########
@@ -454,6 +454,11 @@ syscfg.defs:
restrictions:
- '!GPADC_BATTERY'
+ WATCHDOG_DISABLE_ON_INIT:
+ description: >
+ 'Enable watchdog on init'
+ value: 1
Review Comment:
Yeah I kind of went back and forth with the name as well. So some watchdogs
are auto-started on reset. Some are not. Some are like doomsday devices and
you can't freeze them. This Dialog one is kind of an odd bird. The
implementation we currently have freezes the watchdog during init. So to keep
the default behavior of the driver, I added the DISABLE_ON_INIT and made it the
default (=1).
It didn't matter to me whether we were freezing it or not on init, what
mattered to me was that this was the behavior that was coded into the init
function and that people are currently used to. I am quite happy to just
remove the freeze altogether.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
