sjanc commented on PR #1459: URL: https://github.com/apache/mynewt-nimble/pull/1459#issuecomment-1422618025
Could you follow commit conventions? (prefixes, limit commit subject to 72 characters) eg: "nimble/transport: Fix compilation warning in socket transport" "porting: Fix SYSINIT_PANIC_ASSERT_MSG redefinition" we don't have very strict rules for commit messages but would be good to follow more-or-less what is in history. You can check that with "git log -- PATH_TO_FILE_OR_FOLDER" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
