PROFESSOR-J-K commented on code in PR #1492:
URL: https://github.com/apache/mynewt-nimble/pull/1492#discussion_r1185888556


##########
nimble/drivers/dialog_cmac/src/ble_phy.c:
##########
@@ -1178,6 +1186,8 @@ ble_phy_init(void)
     g_ble_phy_data.phy_whitening = 1;
 #endif
 
+    set_reg32_bits(0x40000904, 0x0004, 1);

Review Comment:
   This code line deals with suppressing a meta-stability issue from raising an 
error condition towards the controller, mainly observed in GF variant. 
Preferably, this should be executed as early as possible and is not related to 
the RF part. Is there any specific reason why ble_rf_init() is recommended? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to