sjanc commented on PR #1504: URL: https://github.com/apache/mynewt-nimble/pull/1504#issuecomment-1571541115
Hi, This requires some explanation of design, functionality etc in commit message (and preferably split into multiple functional commits). Otherwise it might be hard to review 1.2k lines of code... Also, while NimBLE supports ports our main platform is Mynewt and thus you should at least validate compilation and testsuite passing (newt test) when upstreaming code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
