mkiiskila commented on PR #3033:
URL: https://github.com/apache/mynewt-core/pull/3033#issuecomment-1632060214
Thanks for the merge request, however...
I agree with kasjer. This merge request should have 2 line which are getting
changed; the sizes of sector counts
from uint8_t -> uint16_t. Please close this merge request, and open another
one with that change only.
That kind of pull request will get approved.
MPU6050 changes must be removed from this merge request, that is totally
unrelated to this change.
Also, the reason for those changes is not included in the request
description. You can open another one for those.
Whitespace changes within FCB are unnecessary, it makes the request
noisier, and therefore more tedious to review.
I would refrain from doing formatting changes like that as part of
functional change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
