jakkra commented on code in PR #193:
URL: https://github.com/apache/mynewt-newtmgr/pull/193#discussion_r1261580922
##########
nmxact/nmserial/serial_xport.go:
##########
@@ -50,7 +50,7 @@ var errTimeout error = errors.New("Timeout reading from
serial connection")
func NewXportCfg() *XportCfg {
return &XportCfg{
ReadTimeout: 10 * time.Second,
- Mtu: 512,
+ Mtu: 128,
Review Comment:
If you look at the other change you can see that this value was hardcoded
before. This config.mtu was not even used. Hence the previous default
(hardcoded value) was not changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
