andrzej-kaczmarek commented on code in PR #3042: URL: https://github.com/apache/mynewt-core/pull/3042#discussion_r1265234773
########## kernel/os/include/os/arch/sim/os/os_arch.h: ########## @@ -60,6 +60,7 @@ typedef unsigned int os_stack_t; /* sim specific */ struct stack_frame; void os_arch_frame_init(struct stack_frame *sf); +void os_arch_frame_init_64bit(struct stack_frame *sf); Review Comment: probably would be better to have the same prototype regardless of arch and just use preprocessor to check that we build for supported arch (see https://github.com/apache/mynewt-core/pull/3042/commits/c384bec46f7d55339153b832f96b9d539fe7843b#r1265232905) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
