pfyra commented on code in PR #1591: URL: https://github.com/apache/mynewt-nimble/pull/1591#discussion_r1331125788
########## porting/npl/freertos/src/npl_os_freertos.c: ########## @@ -22,6 +22,10 @@ #include <string.h> #include "nimble/nimble_npl.h" +#ifdef NIMBLE_NPL_OS_EXTRA_INCLUDE +#include NIMBLE_NPL_OS_EXTRA_INCLUDE +#endif + Review Comment: I suppose all ARM MCUs have the SCB so it should be enough to include a header file for the HW specific stuff. At least in my case (stm32) it is. I suppose everyone who use this code needs to add an include statement to this file (or modify it further). It is a bit cumbersome to maintain changes to the nimble repo at our end since we want to use the nimble repo as a submodule and it is very close to work without changes. Having a possibility to specify a file to include here makes it possible for us to use nimble without any changes. Perhaps there is a CMSIS file that can be included that specifies the SCB? That might introduce some unwanted dependencies though... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
