sjanc commented on code in PR #1537: URL: https://github.com/apache/mynewt-nimble/pull/1537#discussion_r1341122770
########## nimble/host/src/ble_gap.c: ########## @@ -3817,7 +3846,9 @@ ble_gap_periodic_adv_set_data_validate(uint8_t instance, } int -ble_gap_periodic_adv_set_data(uint8_t instance, struct os_mbuf *data) +ble_gap_periodic_adv_set_data(uint8_t instance, + struct os_mbuf *data, + struct ble_gap_periodic_adv_set_data_params *params) Review Comment: const ########## nimble/host/include/host/ble_gap.h: ########## @@ -1767,10 +1802,14 @@ int ble_gap_periodic_adv_stop(uint8_t instance); * * @param instance Instance ID * @param data Chain containing the periodic advertising data. + * @param params Additional arguments specifying the particulars + of periodic advertising data. * * @return 0 on success or error code on failure. */ -int ble_gap_periodic_adv_set_data(uint8_t instance, struct os_mbuf *data); +int ble_gap_periodic_adv_set_data(uint8_t instance, + struct os_mbuf *data, + struct ble_gap_periodic_adv_set_data_params *params); Review Comment: could be const -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
