sjanc commented on PR #1672: URL: https://github.com/apache/mynewt-nimble/pull/1672#issuecomment-1878396092
Hi, Few general things (I'll have more detailed comments after doing full code review) 1) add support for this in bttester (and maybe btshell) 2) test it with PTS (eg via autopts (https://github.com/auto-pts/auto-pts)) 3) Commit message (title and body) needs improvements 4) Maybe this should gracefully fallback to Write Without Response if link is encrypted? (just a thought, I'm fine with returning error as is now) In general I'm bit reluctant about adding this feature as it is barely used (TBH I've never seen this being used in real applications and have not seen any profile that would require it). But if you need it and above steps are completed I'm not going to block it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
