sjanc commented on code in PR #1673:
URL: https://github.com/apache/mynewt-nimble/pull/1673#discussion_r1461455159
##########
nimble/host/src/ble_gap.c:
##########
@@ -6201,7 +6201,8 @@ ble_gap_unpair(const ble_addr_t *peer_addr)
rc = ble_hs_pvcy_remove_entry(peer_addr->type,
peer_addr->val);
- if (rc != 0) {
+
+ if (rc != 0 && rc != BLE_HS_ERR_HCI_BASE + BLE_ERR_UNK_CONN_ID) {
Review Comment:
add braces around BLE_HS_ERR_HCI_BASE + BLE_ERR_UNK_CONN_ID
##########
nimble/host/src/ble_gap.c:
##########
@@ -6201,7 +6201,8 @@ ble_gap_unpair(const ble_addr_t *peer_addr)
rc = ble_hs_pvcy_remove_entry(peer_addr->type,
peer_addr->val);
- if (rc != 0) {
+
Review Comment:
add a comment why this particular error is allowed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
