andrzej-kaczmarek commented on code in PR #543:
URL: https://github.com/apache/mynewt-newt/pull/543#discussion_r1502403993
##########
newt/repo/version.go:
##########
@@ -126,6 +126,15 @@ func (r *Repo) VersionIsValid(ver newtutil.RepoVersion)
bool {
}
cs, _ := r.downloader.CommitsFor(r.Path(), ver.Commit)
+
+ // For shallow copy commit might not be fetched yet
Review Comment:
this could be actually done regardless of whether repo is shallow or now
the same problem exists if user specifies a commit that is not preset on any
remote branch, e.g. a sha for PR head
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
